Skip to content

fix(windpipe): Fix undefined values serialising into invalid JSON #49

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
giraugh merged 2 commits into from
Jan 21, 2025
Merged

fix(windpipe): Fix undefined values serialising into invalid JSON #49

giraugh merged 2 commits into from
Jan 21, 2025

Conversation

@giraugh
Copy link
Contributor

@giraugh giraugh commented Jan 21, 2025

@giraugh giraugh requested a review from andogq January 21, 2025 05:09
@giraugh giraugh self-assigned this Jan 21, 2025
@changeset-bot
Copy link

changeset-bot bot commented Jan 21, 2025

⚠️ No Changeset found

Latest commit: c9eee96

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

andogq
andogq approved these changes Jan 21, 2025
View reviewed changes
Copy link
Contributor

@andogq andogq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very good find

@giraugh giraugh merged commit 05d6f92 into main Jan 21, 2025
1 check passed
@giraugh giraugh deleted the ewanb/cxp-1117-windpipe-json-serialisation-issue branch January 21, 2025 22:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@andogq andogq andogq approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@giraugh giraugh

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@giraugh @andogq